Skip to content

fix azure blob storage access in e2e tests - #1253

Merged
jklegar merged 3 commits into
feast-dev:masterfrom
jklegar:jacob_fix_tests
Jan 6, 2021
Merged

fix azure blob storage access in e2e tests#1253
jklegar merged 3 commits into
feast-dev:masterfrom
jklegar:jacob_fix_tests

Conversation

@jklegar

@jklegar jklegar commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: fix failing azure e2e test

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@jklegar
fix azure blob storage access
3aebebc 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@feast-ci-bot

feast-ci-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jklegar
To complete the pull request process, please assign pyalex after the PR has been reviewed.
You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jklegar added 2 commits January 5, 2021 21:41
@jklegar
lint
8c848c7 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
bugfix
1776fc1 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@feast-ci-bot

feast-ci-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

@jklegar: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure 1776fc1 link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jklegar
jklegar merged commit 7226bde into feast-dev:master Jan 6, 2021
@feast-ci-bot

feast-ci-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

@jklegar: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: fix failing azure e2e test

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jklegar
jklegar deleted the jacob_fix_tests branch February 4, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

No one assigned

Labels

needs-kind release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jklegar @feast-ci-bot