Skip to content

Apply grpc tracing interceptor on Feast SDK - #1243

Merged
pyalex merged 2 commits into
feast-dev:masterfrom
khorshuheng:tracing-sdk
Jan 4, 2021
Merged

Apply grpc tracing interceptor on Feast SDK#1243
pyalex merged 2 commits into
feast-dev:masterfrom
khorshuheng:tracing-sdk

Conversation

@khorshuheng

@khorshuheng khorshuheng commented Dec 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

What this PR does / why we need it:
This would enable out of the box Tracing support on Golang, Python and Java SDK. If user has registered a GlobalTracer, Feast client will automatically construct a grpc tracing interceptor using the registered tracer. Otherwise, a NoopTracer is used instead.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

gRPC tracing will now be enabled automatically on Feast clients if a global tracer instance is registered.

@khorshuheng khorshuheng added the kind/feature New feature or request label Dec 23, 2020
@khorshuheng khorshuheng changed the title Apply grpc tracing interceptor on Golang and Java SDK Apply grpc tracing interceptor on Feast SDK Dec 24, 2020
@feast-ci-bot

feast-ci-bot commented Jan 4, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Jan 4, 2021

Copy link
Copy Markdown
Collaborator

/lgtm

@khorshuheng
Apply grpc tracing interceptor on Golang and Java SDK
f835b4a 
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@khorshuheng
Apply grpc tracing interceptor on Python SDK
9b2fe2d 
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Jan 4, 2021
@feast-ci-bot

feast-ci-bot commented Jan 4, 2021

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot

feast-ci-bot commented Jan 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@khorshuheng: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure 9b2fe2d link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex
pyalex merged commit a3e6e53 into feast-dev:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

Labels

approved kind/feature New feature or request release-note size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khorshuheng @feast-ci-bot @pyalex