Skip to content

CI should work on python 3.6 - #1237

Merged
pyalex merged 2 commits into
feast-dev:masterfrom
pyalex:ci-python-3.6
Dec 17, 2020
Merged

CI should work on python 3.6#1237
pyalex merged 2 commits into
feast-dev:masterfrom
pyalex:ci-python-3.6

Conversation

@pyalex

@pyalex pyalex commented Dec 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

To guarantee compatibility with python 3.6 (as declared in our setup.py) this PR downgrades python version to 3.6 in CI docker image.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pyalex
should work on python 3.6
f9320c7 
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
khorshuheng
khorshuheng approved these changes Dec 17, 2020
View reviewed changes

@khorshuheng khorshuheng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Dec 17, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng

khorshuheng commented Dec 17, 2020

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-sparkop

@pyalex
latest git
48fdb08 
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Dec 17, 2020
@feast-ci-bot

feast-ci-bot commented Dec 17, 2020

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot

feast-ci-bot commented Dec 17, 2020

Copy link
Copy Markdown
Collaborator

@pyalex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-sparkop 48fdb08 link /test test-end-to-end-sparkop

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex
pyalex merged commit 5b76f9a into feast-dev:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khorshuheng khorshuheng khorshuheng approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@khorshuheng khorshuheng

Labels

approved kind/housekeeping release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pyalex @feast-ci-bot @khorshuheng