Fix tag order for release workflow - #1205
Merged
Merged
Conversation
terryyylim
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
December 1, 2020 02:28
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: terryyylim The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
fix-release-build-order
branch
from
December 1, 2020 02:29
866a61e to
900f5b3
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
pyalex
approved these changes
Dec 1, 2020
pyalex
pushed a commit
that referenced
this pull request
Dec 4, 2020
* Fix tag order Signed-off-by: Terence <terencelimxp@gmail.com> * Tag and push to dockerhub Signed-off-by: Terence <terencelimxp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
Currently, the release workflow tag step indicates the source and target images in the wrong order resulting in the built image to be not found.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: