Skip to content

Add project name to metrics labels in Ingestion Job - #1202

Merged
pyalex merged 1 commit into
feast-dev:masterfrom
pyalex:metrics-add-project-label
Dec 1, 2020
Merged

Add project name to metrics labels in Ingestion Job#1202
pyalex merged 1 commit into
feast-dev:masterfrom
pyalex:metrics-add-project-label

Conversation

@pyalex

@pyalex pyalex commented Nov 30, 2020

Copy link
Copy Markdown
Collaborator

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

To help distinguish (ingestion) metrics from different projects this PR adds project name as one of metrics dimensions.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

project label is added to ingestion job metrics

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex

pyalex commented Nov 30, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-gcp

@pyalex

pyalex commented Nov 30, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-aws

@pyalex

pyalex commented Nov 30, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-gcp

@khorshuheng khorshuheng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Nov 30, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-aws

1 similar comment
@pyalex

pyalex commented Dec 1, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-aws

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@pyalex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-aws c4859f5 link /test test-end-to-end-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex

pyalex commented Dec 1, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-aws

@pyalex
pyalex merged commit 1fe959f into feast-dev:master Dec 1, 2020
pyalex added a commit that referenced this pull request Dec 4, 2020
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants