Skip to content

Option for additional spark configuration - #1198

Closed
mike0sv wants to merge 6 commits into
feast-dev:masterfrom
mike0sv:master
Closed

Option for additional spark configuration#1198
mike0sv wants to merge 6 commits into
feast-dev:masterfrom
mike0sv:master

Conversation

@mike0sv

@mike0sv mike0sv commented Nov 26, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: mike0sv mike0sv@gmail.com

What this PR does / why we need it:
Adds an option for additional spark configuration
Which issue(s) this PR fixes:

Fixes #1168

Does this PR introduce a user-facing change?:

Added SPARK_ADDITIONAL_OPTS config option to enable users to provide additional config for Spark jobs

@mike0sv
Option for additional spark configuration
b98e6cd 
Signed-off-by: mike0sv <mike0sv@gmail.com>
@feast-ci-bot

feast-ci-bot commented Nov 26, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mike0sv
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

feast-ci-bot commented Nov 26, 2020

Copy link
Copy Markdown
Collaborator

Hi @mike0sv. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mike0sv
standalone and dataproc config
eb3709c 
Signed-off-by: mike0sv <mike0sv@gmail.com>
@mike0sv
dataproc config
6ec62e4 
Signed-off-by: mike0sv <mike0sv@gmail.com>
@mike0sv
linter
ad05891 
Signed-off-by: mike0sv <mike0sv@gmail.com>
@woop

woop commented Nov 26, 2020

Copy link
Copy Markdown
Member

/kind feature
/ok-to-test

@mike0sv
default value
0485841 
Signed-off-by: mike0sv <mike0sv@gmail.com>
@mike0sv
emr job and fix import error by rename
61a6079 
Signed-off-by: mike0sv <mike0sv@gmail.com>
@mike0sv

mike0sv commented Nov 30, 2020

Copy link
Copy Markdown
Contributor Author

/retest

@woop woop mentioned this pull request Dec 16, 2020
Merged
@mike0sv

mike0sv commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

Hey guys! I've been pretty preoccupied lately and didnt have the time to work on this. But I'll return to this as soon as I have the time

@feast-ci-bot

feast-ci-bot commented Jan 28, 2021

Copy link
Copy Markdown
Collaborator

@mike0sv: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-gcp 61a6079 link /test test-end-to-end-gcp
test-end-to-end-sparkop 61a6079 link /test test-end-to-end-sparkop
test-end-to-end-azure 61a6079 link /test test-end-to-end-azure
test-telemetry 61a6079 link /test test-telemetry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop

woop commented Feb 8, 2021

Copy link
Copy Markdown
Member

@mike0sv apologies about the slow feedback on this PR. We need to move it to https://github.com/feast-dev/feast-spark though, since that will be the new home for Spark related code.

@woop woop closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

No one assigned

Labels

kind/feature New feature or request ok-to-test release-note size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Additional configuration options for Spark jobs

3 participants

@mike0sv @feast-ci-bot @woop