Fix missing name variable instantiation - #1166
Merged
Merged
Conversation
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
November 16, 2020 03:05
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
fix-ingest-method
branch
from
November 16, 2020 03:10
5f4eb44 to
bac20e0
Compare
Member
|
Should we add a test somewhere as well to prevent regression? |
woop
approved these changes
Nov 16, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terryyylim, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pyalex
pushed a commit
that referenced
this pull request
Nov 24, 2020
Signed-off-by: Terence <terencelimxp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
Currently, in
ingestmethod of python SDK client, iffeature_tableparameter is a str, thenamevariable will not be instantiated correctly. This PR addresses that.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: