Expires Redis Keys based on Feature Table Max Age - #1161
Merged
Conversation
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
November 13, 2020 08:23
Member
|
/retest |
khorshuheng
force-pushed
the
redis-key-ttl
branch
2 times, most recently
from
November 17, 2020 02:14
87c7ec5 to
c537690
Compare
khorshuheng
force-pushed
the
redis-key-ttl
branch
2 times, most recently
from
November 17, 2020 05:37
f1a496b to
c537690
Compare
khorshuheng
force-pushed
the
redis-key-ttl
branch
from
November 17, 2020 07:33
c537690 to
46d3e43
Compare
Member
|
@khorshuheng can you please add a description? This PR has no information. |
khorshuheng
force-pushed
the
redis-key-ttl
branch
from
November 20, 2020 01:56
46d3e43 to
9bf661d
Compare
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
redis-key-ttl
branch
from
November 20, 2020 02:10
9bf661d to
0b787c3
Compare
pyalex
reviewed
Nov 20, 2020
pyalex
reviewed
Nov 20, 2020
| .map(value => decodeTimestamp(value)) | ||
| } | ||
|
|
||
| override def newExpiryTimestamp( |
Collaborator
There was a problem hiding this comment.
This is not really persistence related method. Maybe move it to RedisSinkRelation?
Collaborator
There was a problem hiding this comment.
you can move MAX_EXPIRED_TIMESTAMP to package level
…edisSinkRelation Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
pyalex
reviewed
Nov 23, 2020
| keyTTL should (be <= (r.getEventTimestamp.getSeconds + maxAge - ingestionTimeUnix / 1000) and be > 0L) | ||
| } | ||
|
|
||
| val increasedMaxAge = 86400 * 2 |
Collaborator
There was a problem hiding this comment.
Can we have test for max age = 0 instead, since this flow was already tested with Batch Pipeline?
Member
So how does an administrator force a TTL? |
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Collaborator
|
/test test-end-to-end-gcp |
pyalex
approved these changes
Nov 24, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
pyalex
pushed a commit
that referenced
this pull request
Nov 24, 2020
* Expires Redis Keys based on Feature Table Max Age Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> * Remove redundant generics, move expiry eventimestamp computation to RedisSinkRelation Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> * Persist the key if the expiry date is equal to max timestamp Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> * Add more test cases Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> Co-authored-by: Khor Shu Heng <khor.heng@gojek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Khor Shu Heng khor.heng@gojek.com
What this PR does / why we need it:
Since the release of Feast 0.8, the Redis ingestion is performed via Spark ingestion module rather than the existing Redis storage module. Hence, #955 is not applicable to Feast 0.8.
For the current implementation, instead of a global value of ttl which would be applicable to all Redis key, the ttl will be computed based on the max ages of all the feature tables associated with the Redis Key. For example, if two feature table are associated with the Redis key, the ttl will be computed as follows:
In the event where any of the feature table associated with the Redis key has max age set to 0, ttl will not be set.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: