Skip to content

Fix stencil client serialization issue #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyalex merged 1 commit into from
Nov 10, 2020
Merged

Fix stencil client serialization issue #1147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions spark/ingestion/src/main/scala/feast/ingestion/registry/proto/StencilProtoRegistry.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,15 @@ import com.gojek.de.stencil.StencilClientFactory
import com.gojek.de.stencil.client.StencilClient

class StencilProtoRegistry(val url: String) extends ProtoRegistry {
@transient
private var _stencilClient: StencilClient = _

val stencilClient: StencilClient =
StencilClientFactory.getClient(url, Collections.emptyMap[String, String])
def stencilClient: StencilClient = {
if (_stencilClient == null) {
_stencilClient = StencilClientFactory.getClient(url, Collections.emptyMap[String, String])
}
_stencilClient
}

override def getProtoDescriptor(className: String): Descriptors.Descriptor = {
stencilClient.get(className)
Expand Down