Skip to content

[E2E] In Streaming Test filter kafka consumers by group id prefix - #1145

Merged
pyalex merged 2 commits into
feast-dev:masterfrom
pyalex:named-kafka-reader
Nov 6, 2020
Merged

[E2E] In Streaming Test filter kafka consumers by group id prefix#1145
pyalex merged 2 commits into
feast-dev:masterfrom
pyalex:named-kafka-reader

Conversation

@pyalex

@pyalex pyalex commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-gcp

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex

pyalex commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end

@pyalex

pyalex commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-gcp

@pyalex pyalex changed the title Prefix for kafka consumer group in IngestionJob [E2E] In Streaming Test filter kafka consumers by group id prefix Nov 6, 2020
@pyalex
pyalex merged commit b2901a2 into feast-dev:master Nov 6, 2020
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@pyalex: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-gcp 3743869 link /test test-end-to-end-gcp

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants