Skip to content

Add Prow to AWS codebuild trigger - #1133

Merged
woop merged 1 commit into
feast-dev:masterfrom
oavdeev:aws-prow
Nov 4, 2020
Merged

Add Prow to AWS codebuild trigger#1133
woop merged 1 commit into
feast-dev:masterfrom
oavdeev:aws-prow

Conversation

@oavdeev

@oavdeev oavdeev commented Nov 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Oleg Avdeev oleg.v.avdeev@gmail.com

What this PR does / why we need it:
Trigger AWS cicd from prow. It won't succeed yet since that would require the other AWS CICD PR to land, but will allow me to test the other PR.

Does this PR introduce a user-facing change?:

NONE

@oavdeev
add prow -> aws codebuild trigger
04b4c75 
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@woop woop changed the title add prow -> aws codebuild trigger Add Prow to AWS codebuild trigger Nov 4, 2020
@feast-ci-bot

feast-ci-bot commented Nov 4, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Nov 4, 2020

Copy link
Copy Markdown
Member

/lgtm

@oavdeev

oavdeev commented Nov 4, 2020

Copy link
Copy Markdown
Collaborator Author

/kind housekeeping

@feast-ci-bot

feast-ci-bot commented Nov 4, 2020

Copy link
Copy Markdown
Collaborator

@oavdeev: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-aws 04b4c75 link /test test-end-to-end-aws
test-end-to-end-gcp 04b4c75 link /test test-end-to-end-gcp

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop
woop merged commit 620e3e4 into feast-dev:master Nov 4, 2020
@feast-ci-bot

feast-ci-bot commented Nov 4, 2020

Copy link
Copy Markdown
Collaborator

@oavdeev: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

Signed-off-by: Oleg Avdeev oleg.v.avdeev@gmail.com

What this PR does / why we need it:
Trigger AWS cicd from prow. It won't succeed yet since that would require the other AWS CICD PR to land, but will allow me to test the other PR.

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oavdeev
oavdeev deleted the aws-prow branch November 4, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels

approved kind/housekeeping lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oavdeev @feast-ci-bot @woop