Allow user to specify custom secrets to be mounted on Feast Serving and Feast Core pods - #1127
Merged
Merged
Conversation
…nd Feast Core pods Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
November 3, 2020 09:02
pyalex
approved these changes
Nov 3, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Collaborator
|
/test test-end-to-end-gcp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Signed-off-by: Khor Shu Heng khor.heng@gojek.com
What this PR does / why we need it:
Currently, users has no way to mount existing Kubernetes secrets to Feast services. One of the consequences of this is that Feast Core and Feast Serving would not be able to use GCP authentication, since there is no way to set up Google Application Credential.
This PR adds a new helm values called
secrets, which the user can provide the list of kubernetes secrets to be mounted. They can then use envoverride variable to setup the credentials.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: