Skip to content

Ability to run e2e tests in non-default project #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyalex merged 1 commit into from
Nov 3, 2020
Merged

Ability to run e2e tests in non-default project #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/e2e/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def pytest_addoption(parser):
parser.addoption("--redis-cluster", action="store_true")
parser.addoption("--feast-version", action="store")
parser.addoption("--bq-project", action="store")
parser.addoption("--feast-project", action="store", default="default")


def pytest_runtest_setup(item):
Expand Down
11 changes: 8 additions & 3 deletions tests/e2e/fixtures/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def feast_client(
enable_auth,
):
if pytestconfig.getoption("env") == "local":
return Client(
c = Client(
core_url=f"{feast_core[0]}:{feast_core[1]}",
serving_url=f"{feast_serving[0]}:{feast_serving[1]}",
spark_launcher="standalone",
Expand All @@ -36,8 +36,8 @@ def feast_client(
),
)

if pytestconfig.getoption("env") == "gcloud":
return Client(
elif pytestconfig.getoption("env") == "gcloud":
c = Client(
core_url=f"{feast_core[0]}:{feast_core[1]}",
serving_url=f"{feast_serving[0]}:{feast_serving[1]}",
spark_launcher="dataproc",
Expand All @@ -52,6 +52,11 @@ def feast_client(
local_staging_path, "historical_output"
),
)
else:
raise KeyError(f"Unknown environment {pytestconfig.getoption('env')}")

c.set_project(pytestconfig.getoption("feast_project"))
return c


@pytest.fixture(scope="session")
Expand Down