Skip to content

Allow spark expressions in field mapping during Ingestion - #1122

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pyalex:allow-expr
Nov 2, 2020
Merged

Allow spark expressions in field mapping during Ingestion#1122
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pyalex:allow-expr

Conversation

@pyalex

@pyalex pyalex commented Nov 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

Instead of just map columns with different name - this PR allows to use expressions (spark style) to enable simple transformations of features during ingestion.
Example

fieldMapping = {
   "feature1": "cos(feature1)",
   "feature2": "feature2 / feature1"
}

Available functions: https://spark.apache.org/docs/2.3.1/api/sql/index.html

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

@pyalex
allow spark expression in field mapping
3627d87 
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex pyalex added the kind/feature New feature or request label Nov 2, 2020
@khorshuheng

khorshuheng commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

/test python-sdk-integration-test

@woop

woop commented Nov 2, 2020

Copy link
Copy Markdown
Member

/lgtm

@pyalex

pyalex commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator Author

/test python-sdk-integration-test

@feast-ci-bot

feast-ci-bot commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 8d1326f into feast-dev:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels

approved kind/feature New feature or request lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pyalex @khorshuheng @woop @feast-ci-bot