Add feature table deletion - #1114
Merged
Merged
Conversation
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
October 30, 2020 02:09
terryyylim
force-pushed
the
feature-table-deletion
branch
from
October 30, 2020 02:11
aede9de to
814f391
Compare
Member
|
/test test-end-to-end-aws |
pyalex
reviewed
Nov 2, 2020
pyalex
reviewed
Nov 2, 2020
pyalex
reviewed
Nov 2, 2020
pyalex
reviewed
Nov 2, 2020
terryyylim
force-pushed
the
feature-table-deletion
branch
from
November 2, 2020 04:55
6bcde58 to
5d1e653
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
feature-table-deletion
branch
from
November 2, 2020 04:56
5d1e653 to
b06298e
Compare
pyalex
reviewed
Nov 2, 2020
pyalex
reviewed
Nov 2, 2020
terryyylim
force-pushed
the
feature-table-deletion
branch
from
November 2, 2020 05:04
b06298e to
820cff2
Compare
Member
Author
|
/retest |
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
feature-table-deletion
branch
from
November 2, 2020 07:26
820cff2 to
cd50a3f
Compare
Member
Author
|
/retest |
Signed-off-by: Terence <terencelimxp@gmail.com>
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
pyalex
approved these changes
Nov 2, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Collaborator
|
/test test-end-to-end-aws |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
This PR enables feature table deletion. The following has been implemented:
is_deletedflag to check if a table is deleted or notdelete_feature_tablemethod to Python SDKWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: