Skip to content

Scaffolding for integration tests - #1113

Merged
khorshuheng merged 3 commits into
feast-dev:masterfrom
khorshuheng:integration-test
Oct 29, 2020
Merged

Scaffolding for integration tests#1113
khorshuheng merged 3 commits into
feast-dev:masterfrom
khorshuheng:integration-test

Conversation

@khorshuheng

Copy link
Copy Markdown
Collaborator

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

What this PR does / why we need it:
This PR add integration tests stage to prow. Once this is merged to master, we will be able to start adding integration test and run it via CI.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Comment thread tests/integration/conftest.py Outdated


def pytest_runtest_setup(item):
if "incremental" in item.keywords:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use this keyword anymore

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Oct 29, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Oct 29, 2020
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@khorshuheng
khorshuheng merged commit 24de261 into feast-dev:master Oct 29, 2020
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@khorshuheng: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

What this PR does / why we need it:
This PR add integration tests stage to prow. Once this is merged to master, we will be able to start adding integration test and run it via CI.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@khorshuheng: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-gcp 60bb8c5 link /test test-end-to-end-gcp
test-end-to-end 60bb8c5 link /test test-end-to-end

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants