Add historical retrieval via job service - #1107
Conversation
93bb69e to
cf9e023
Compare
|
/kind feature |
There was a problem hiding this comment.
renamed this for consistency with the existing Job.cancel method
There was a problem hiding this comment.
Removed a bunch of unused (or not yet used) parameters here, we can always add them back later.
There was a problem hiding this comment.
changed this for consistency with client API
There was a problem hiding this comment.
another change for consistency with client API
There was a problem hiding this comment.
I don't expect people to use this in production, but it is handy for debugging.
There was a problem hiding this comment.
Had to bump this since some job service methods in turn make calls to AWS/GCP APIs. Sometimes those take a while especially in development env where your job service is not running in the cloud itself.
There was a problem hiding this comment.
We should prob unify those params with core service in another PR.
|
/kind feature |
pyalex
left a comment
There was a problem hiding this comment.
This PR needs tests, both unit & e2e
|
/retest |
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
e7394a3 to
0b4510d
Compare
|
/retest |
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
0b4510d to
278f022
Compare
|
/test test-end-to-end |
278f022 to
68fb26b
Compare
|
@oavdeev: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it:
This implements end-to-end flow for historical retrieval via job service. Tested only manually for now, until we include job service setup in e2e tests.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: