Skip to content

Allow entities and features to be updated - #1105

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:allow-entity-feature-update
Oct 29, 2020
Merged

Allow entities and features to be updated#1105
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:allow-entity-feature-update

Conversation

@terryyylim

Copy link
Copy Markdown
Member

Signed-off-by: Terence terencelimxp@gmail.com

What this PR does / why we need it:
As we're moving towards supporting deletion of feature tables, this is a step towards it by allowing changes to:

  • the entities in a feature table
  • the features and their types in a feature table

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Users can now update their entities and features in a feature table.

@terryyylim terryyylim added kind/feature New feature or request area/core labels Oct 28, 2020
@terryyylim
terryyylim requested a review from zhilingc as a code owner October 28, 2020 07:33
Signed-off-by: Terence <terencelimxp@gmail.com>
@terryyylim
terryyylim force-pushed the allow-entity-feature-update branch from ca36585 to 22e2c2a Compare October 28, 2020 08:22
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Oct 29, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants