Skip to content

disable statsd by default for spark - #1089

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
oavdeev:no-default-statsd-spark
Oct 22, 2020
Merged

disable statsd by default for spark#1089
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
oavdeev:no-default-statsd-spark

Conversation

@oavdeev-tt

@oavdeev-tt oavdeev-tt commented Oct 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
It causes mysterious NoClassDefFound errors on EMR so disabling it for now by default

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@oavdeev
disable statsd by default for spark
d9a5290 
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@oavdeev-tt

oavdeev-tt commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

/assign @pyalex

@feast-ci-bot

feast-ci-bot commented Oct 22, 2020

Copy link
Copy Markdown
Collaborator

Hi @oavdeev-tt. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oavdeev-tt

oavdeev-tt commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

/kind housekeeping

@feast-ci-bot

feast-ci-bot commented Oct 22, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev-tt, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Oct 22, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 53d16a6 into feast-dev:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

Labels

approved kind/housekeeping lgtm needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oavdeev-tt @feast-ci-bot @pyalex @oavdeev