Skip to content

Fix env var names for jupyter terraform config - #1085

Merged
woop merged 1 commit into
feast-dev:masterfrom
oavdeev:feast-jupyter-tweaks
Oct 22, 2020
Merged

Fix env var names for jupyter terraform config#1085
woop merged 1 commit into
feast-dev:masterfrom
oavdeev:feast-jupyter-tweaks

Conversation

@oavdeev

@oavdeev oavdeev commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@oavdeev
more jupyter terraform tweaks
f570e52 
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@feast-ci-bot

feast-ci-bot commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oavdeev
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oavdeev

oavdeev commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator Author

/kind bug

@feast-ci-bot

feast-ci-bot commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator

@oavdeev: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end f570e52 link /test test-end-to-end

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop
woop merged commit eee9a9a into feast-dev:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

No one assigned

Labels

kind/bug size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oavdeev @feast-ci-bot @woop