Add unit test for historical retrieval with panda dataframe - #1073
Merged
feast-ci-bot merged 1 commit intoOct 22, 2020
Conversation
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
October 20, 2020 07:17
pyalex
approved these changes
Oct 21, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
khorshuheng
force-pushed
the
fix-panda-entity-source
branch
from
October 21, 2020 05:38
10f17d4 to
a0cd6fb
Compare
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
fix-panda-entity-source
branch
from
October 21, 2020 05:40
a0cd6fb to
5fab886
Compare
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Khor Shu Heng khor.heng@gojek.com
What this PR does / why we need it:
There is currently no unit test for cases where the input to the historical feature retrieval output is a panda dataframe. This PR add the test.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: