Skip to content

Refactor Spark Job launcher API - #1060

Merged
pyalex merged 2 commits into
feast-dev:masterfrom
pyalex:refactor-launcher
Oct 15, 2020
Merged

Refactor Spark Job launcher API#1060
pyalex merged 2 commits into
feast-dev:masterfrom
pyalex:refactor-launcher

Conversation

@pyalex

@pyalex pyalex commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:
Launcher methods to accept JobParameters as object.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex pyalex changed the title Refactor job launcher API Refactor Spark Job launcher API Oct 15, 2020
Comment thread sdk/python/feast/pyspark/abc.py
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex

pyalex commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-auth

@pyalex
pyalex merged commit 39c9fbe into feast-dev:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants