Embed ui build & packaging into core's build - #106
Merged
Conversation
Collaborator
Author
Collaborator
|
/lgtm |
Collaborator
|
wait what? |
Contributor
|
Does this get packaged into core's docker image? If not, can't it just be triggered via make. Yarn can be installed the same way we install maven, as part of the docker image we use to run the builds? |
Collaborator
Author
|
It will be part of core's jar file thus it will also be part of core's docker image |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aniketpalu
pushed a commit
to aniketpalu/feast
that referenced
this pull request
Dec 26, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Srihari1192
pushed a commit
to Srihari1192/feast
that referenced
this pull request
Apr 15, 2026
fix: Fixed config registry issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #105