Replace Data Source specific format options with DataFormat message - #1049
Merged
Conversation
pyalex
reviewed
Oct 14, 2020
pyalex
reviewed
Oct 14, 2020
Collaborator
Author
|
/hold due to Protobuf API change |
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
…ve objects. Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
…, DataFormat specs Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
…ables Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
…e current API Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
…ages Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
DataFormat.proto Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
messages Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
…d by git Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
… instead of expected str Signed-off-by: Zhu Zhanyan <program.nom@gmail.com>
pyalex
approved these changes
Oct 19, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Collaborator
|
/unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add data format messages to represent as data formats:
FileFormatwill replacefile_formatin FileOptionsStreamFormatclass_path` in Kafka and KinesisOptions.SourceType(ieAvroFormatandProtoFormatfor Kafka).AvroFormatProtobuf messageWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: