Skip to content

Adding support for custom grpc dial options in Go SDK - #1043

Merged
woop merged 1 commit into
feast-dev:masterfrom
ankurs:fix/go-grpc-dial-option
Oct 23, 2020
Merged

Adding support for custom grpc dial options in Go SDK#1043
woop merged 1 commit into
feast-dev:masterfrom
ankurs:fix/go-grpc-dial-option

Conversation

@ankurs

@ankurs ankurs commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR adds support for custom grpc dial options in Go SDK. Currently there is now way for the clients to specify custom grpc.DialOption

Which issue(s) this PR fixes:
Fixes #1042

Does this PR introduce a user-facing change?:

Adding support for custom grpc dial options in Go SDK

@feast-ci-bot

feast-ci-bot commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankurs
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

feast-ci-bot commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

Hi @ankurs. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop

woop commented Oct 13, 2020

Copy link
Copy Markdown
Member

/ok-to-test

@woop woop added the kind/feature New feature or request label Oct 13, 2020
@ankurs

ankurs commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

Thats weird a Java test failed, I didn't touch anything that might affect it

@ankurs

ankurs commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

/retest

@ankurs

ankurs commented Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

@woop can you please help me run the tests again ?

@woop

woop commented Oct 15, 2020

Copy link
Copy Markdown
Member

/retest

@ankurs

ankurs commented Oct 23, 2020

Copy link
Copy Markdown
Contributor Author

@woop looks like this is still not triggered

@woop

woop commented Oct 23, 2020

Copy link
Copy Markdown
Member

@woop looks like this is still not triggered

@ankurs, my apologies. The test you are looking at is a GitHub action. it should be rerun through the UI. I have just triggered it.

@woop
woop merged commit 1b2bcc6 into feast-dev:master Oct 23, 2020
@ankurs

ankurs commented Oct 23, 2020

Copy link
Copy Markdown
Contributor Author

Thanks!

@ankurs
ankurs deleted the fix/go-grpc-dial-option branch November 3, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

No one assigned

Labels

kind/feature New feature or request ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for custom grpc dial options in Go SDK

3 participants

@ankurs @feast-ci-bot @woop