terraform config for aws - #1033
Merged
Merged
Conversation
oavdeev
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
October 7, 2020 09:00
Contributor
|
/kind feature |
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
jmelinav
reviewed
Oct 8, 2020
| vpc_id = module.vpc.vpc_id | ||
| } | ||
|
|
||
| module "vpc" { |
Collaborator
There was a problem hiding this comment.
Will it be possible to provide a way to use existing vpc?
jmelinav
reviewed
Oct 8, 2020
|
|
||
| vpc_id = module.vpc.vpc_id | ||
|
|
||
| worker_groups = [ |
Collaborator
There was a problem hiding this comment.
May be this should be a variable with default values?
Member
|
We're going to merge this as an example. We can refactor the implementation into a module in a new PR. @jmelinav |
woop
approved these changes
Oct 9, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This contains an example tf config for setting up Feast on AWS. This includes:
Does not (yet) include:
Does this PR introduce a user-facing change?: