Provide stable jobName in RowMetrics labels - #1028
Merged
Merged
Conversation
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
khorshuheng
approved these changes
Oct 7, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Collaborator
|
/lgtm |
pyalex
added a commit
to pyalex/feast
that referenced
this pull request
Oct 7, 2020
* stable job name in row metrics Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * fix test Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * fix test Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
added a commit
that referenced
this pull request
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Every time job is being restarted metrics labels produced by ingestion job are changed. Thus it can be treated as completely different metric (in prometheus terms).
This PR changes jobName label in row metrics to produce stable metrics between restarts.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: