Streaming Ingestion Pipeline with Spark - #1027
Merged
Merged
Conversation
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
October 7, 2020 05:53
pyalex
force-pushed
the
spark-streaming
branch
2 times, most recently
from
October 7, 2020 06:12
2b22741 to
2714789
Compare
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
force-pushed
the
spark-streaming
branch
from
October 12, 2020 03:24
30fb2be to
aaa39aa
Compare
oavdeev
approved these changes
Oct 12, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR replaces current (beam) Ingestion Job with spark version. However, several changes are introduced:
FeatureTableconfiguration.Currently there are two ways to make protobuf class available for job in runtime:
This option has a limitation that compiled class must be linked to shadowed protobuf library
com.google.protobuf.vendorsince in our job we had to shadow protobuf due to conflicts with spark dependencies.
*Arbitrary protobuf has some limitations.
oneof,google.protobuf.Anyare not supported. ThusFeatureRowcan't be input to new streaming pipeline.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: