Skip to content

Run offline-to-online ingestion job on EMR - #1026

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
oavdeev:emr-offline-to-online
Oct 12, 2020
Merged

Run offline-to-online ingestion job on EMR#1026
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
oavdeev:emr-offline-to-online

Conversation

@oavdeev

@oavdeev oavdeev commented Oct 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This code runs the spark job on EMR. It also add a CLI command to kick off the job for debugging, but I expect this code will primarily be run by the upcoming job service (mainly because it requires a non-trivial amount of configuration).

@feast-ci-bot

feast-ci-bot commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

Hi @oavdeev. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oavdeev
oavdeev force-pushed the emr-offline-to-online branch from b43418a to 4a5018f Compare October 7, 2020 06:52
@woop

woop commented Oct 7, 2020

Copy link
Copy Markdown
Member

/ok-to-test

@oavdeev
oavdeev force-pushed the emr-offline-to-online branch 5 times, most recently from c2d0c7b to b559ecf Compare October 7, 2020 16:11
@oavdeev

oavdeev commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator Author

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 7, 2020
@oavdeev
oavdeev force-pushed the emr-offline-to-online branch 2 times, most recently from 606e948 to 990af1e Compare October 9, 2020 09:36
@oavdeev
EMR support for offline-to-online job
a01ee51 
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@oavdeev oavdeev changed the title [WIP] Run offline-to-online ingestion job on EMR Run offline-to-online ingestion job on EMR Oct 9, 2020
@oavdeev
oavdeev force-pushed the emr-offline-to-online branch from 990af1e to a01ee51 Compare October 9, 2020 11:26
@feast-ci-bot

feast-ci-bot commented Oct 12, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Oct 12, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 42bf26a into feast-dev:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

Labels

approved kind/feature New feature or request lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oavdeev @feast-ci-bot @woop @pyalex