Batch Ingestion Job rewritten on Spark - #1020
Merged
Merged
Conversation
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
September 29, 2020 07:28
woop
reviewed
Sep 29, 2020
woop
reviewed
Sep 29, 2020
woop
reviewed
Sep 29, 2020
Member
There was a problem hiding this comment.
Can the version come from build-info?
Collaborator
Author
There was a problem hiding this comment.
Not solved yet. Added ToDo
woop
reviewed
Sep 29, 2020
woop
reviewed
Oct 5, 2020
pyalex
force-pushed
the
spark
branch
2 times, most recently
from
October 5, 2020 10:05
58adb85 to
f92c4f0
Compare
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
force-pushed
the
spark
branch
7 times, most recently
from
October 6, 2020 04:37
2a6ec88 to
f8772d1
Compare
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Member
|
/lgtm |
woop
approved these changes
Oct 6, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of simplification of ingestion flow this PR proposes to create separate job per each FeatureSet per Batch / Streaming mode.
Spark implementation of Batch Ingestion has next flow
What's not implemented (in comparison to Beam job):
New spark jobs utilize spark's standard metrics reporting. However, I had to fork StatsD Reporter to support metrics with tags (which is extensions of standard protocol (see https://github.com/prometheus/statsd_exporter#tagging-extensions )).
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes https://github.com/feast-dev/feast/projects/9#card-45746519
Does this PR introduce a user-facing change?: