Skip to content

Update tests with bool list#1012

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:add-bool-list-test
Sep 17, 2020
Merged

Update tests with bool list#1012
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:add-bool-list-test

Conversation

@terryyylim

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Boolean lists are already supported when using python arrays. This PR update tests to reflect that.

Which issue(s) this PR fixes:

Fixes #341

Does this PR introduce a user-facing change?:

NONE

@terryyylim

Copy link
Copy Markdown
Member Author

/retest

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit d887b37 into feast-dev:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean list is not working with PyArrow

3 participants