Skip to content

In redis retrieval call fallback only when there's missing keys #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Sep 16, 2020
Merged

In redis retrieval call fallback only when there's missing keys #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...s/src/main/java/feast/storage/connectors/redis/retriever/RedisClusterOnlineRetriever.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,10 @@ private List<byte[]> sendMultiGet(List<RedisKey> keys) {
.boxed()
.collect(Collectors.toList());

if (indexMissingValue.isEmpty()) {
return redisValues;
}

byte[][] fallbackBinaryKeys =
indexMissingValue.stream()
.map(i -> fallbackSerializer.serialize(keys.get(i)))
Expand Down
9 changes: 7 additions & 2 deletions ...c/test/java/feast/storage/connectors/redis/retriever/RedisClusterOnlineRetrieverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
import static org.mockito.MockitoAnnotations.initMocks;

import com.google.common.collect.ImmutableList;
Expand Down Expand Up @@ -147,7 +147,9 @@ public void shouldReturnResponseWithValuesIfKeysPresent() {
List<KeyValue<byte[], byte[]>> featureRowBytes = Lists.newArrayList(keyValue1, keyValue2);

OnlineRetriever redisClusterOnlineRetriever =
new RedisClusterOnlineRetriever.Builder(connection, serializer).build();
new RedisClusterOnlineRetriever.Builder(connection, serializer)
.withFallbackSerializer(fallbackSerializer)
.build();
when(syncCommands.mget(serializedKey1, serializedKey2)).thenReturn(featureRowBytes);

List<Optional<FeatureRow>> expected =
Expand All @@ -174,6 +176,9 @@ public void shouldReturnResponseWithValuesIfKeysPresent() {
List<Optional<FeatureRow>> actual =
redisClusterOnlineRetriever.getOnlineFeatures(entityRows, featureSetRequest);
assertThat(actual, equalTo(expected));

// check that fallback is used only when there's something to fallback
verify(syncCommands, never()).mget();
}

@Test
Expand Down