Forward port Lint Version script fixes#1008
Conversation
There was a problem hiding this comment.
Actual occurrences is greater than that expected occurrences when both pom.xml and tag versions the same. This is not a issue when pom.xml version is SNAPSHOT, but when its not in SNAPSHOT form, lint version scripts will flag extra occurrences and fail.
There was a problem hiding this comment.
maybe [[ "${VERSION_WITHOUT_PREFIX}" == "${HIGHEST_SEMVER_TAG:1}" ]] ?
There was a problem hiding this comment.
[] implies the test command. According to its manpage, it uses single = for string comparison.
|
/test test-end-to-end-redis-cluster |
* Fixes issue where lint-version sorts prerelease versions higher than actual stable version. * Refactor out version parsing from tags into get_tag_release common function. * Use get_tag_release in master docker push workflow.
|
/test test-end-to-end-auth |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it:
Forward ports lint version script fixes:
v0.7.0-rc.3was higher sorted thanv0.7.0)get_tag_release()common function.get_tag_releasein master docker push workflow to determine highest merged versioned tag.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: