Skip to content

Add validation for dataflow region #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Sep 17, 2020
Merged

Add validation for dataflow region #1005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion job-controller/src/main/java/feast/jobcontroller/runner/dataflow/DataflowRunnerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package feast.jobcontroller.runner.dataflow;

import feast.common.validators.OneOfStrings;
import feast.jobcontroller.runner.option.RunnerConfig;
import feast.proto.core.RunnerProto.DataflowRunnerConfigOptions;
import java.util.Map;
Expand Down Expand Up @@ -55,7 +56,23 @@ public DataflowRunnerConfig(DataflowRunnerConfigOptions runnerConfigOptions) {
@NotBlank public String project;

/* The Google Compute Engine region for creating Dataflow jobs. */
@NotBlank public String region;
@OneOfStrings({
"us-west1",
"us-central1",
"us-east1",
"us-east4",
"northamerica-northeast1",
"europe-west1",
"europe-west2",
"europe-west3",
"europe-west4",
"asia-southeast1",
"asia-east1",
"asia-northeast1",
"australia-southeast1"
})
@NotBlank
public String region;

/* GCP availability zone for operations. */
@NotBlank public String workerZone;
Expand Down