Skip to content

Fix Go SDK extra colon in metadata header for Authentication #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Sep 14, 2020
Merged

Fix Go SDK extra colon in metadata header for Authentication #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312f0ec
Fix Go SDK outputing extra ":" in metadata header for authentication …
mrzzy Sep 13, 2020
6273290
Fix go test
mrzzy Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/go/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func (provider *Credential) GetRequestMetadata(ctx context.Context, uri ...strin
return map[string]string{}, nil
}
return map[string]string{
"Authorization": "Bearer: " + token.AccessToken,
"Authorization": "Bearer " + token.AccessToken,
}, nil
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/go/auth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func TestCredentials(t *testing.T) {
t.Errorf("Expected authentication metadata with key: '%s'", authKey)
}

expectedVal := "Bearer: " + tc.want
expectedVal := "Bearer " + tc.want
if meta[authKey] != expectedVal {
t.Errorf("Expected authentication metadata with value: '%s' Got instead: '%s'", expectedVal, meta[authKey])
}
Expand Down