Skip to content

Add override for serving service static ip - #100

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
zhilingc:chart-fix
Jan 23, 2019
Merged

Add override for serving service static ip#100
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
zhilingc:chart-fix

Conversation

@zhilingc

Copy link
Copy Markdown
Collaborator

So that we can reserve a fixed address for serving (and not just core).

Documentation updated as well.

@pradithya

Copy link
Copy Markdown
Collaborator

/lgtm

@woop

woop commented Jan 23, 2019

Copy link
Copy Markdown
Member

/approve

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 19db163 into feast-dev:master Jan 23, 2019
Srihari1192 added a commit to Srihari1192/feast that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants