Skip to content

Fix caching in Github Workflows #4056

Closed

Description

@tokoko

Caches are almost never hit in CI workflows for pip install step despite taking considerable time for retrieval and upload sometimes.

Possible problems:

  • We are using old version of cache action
  • caches are scoped to branches, so for unit tests they are always recreated for new PRs. For integration tests, they should still work fine as they are ran with pull_request_target (?)

Activity

  1. tokoko commented on Apr 1, 2024

    @tokoko
    CollaboratorAuthor
  2. tmihalac commented on Apr 10, 2024

    @tmihalac
    Contributor

    @tokoko
    I think I saw a problem with with the caches, but before coming to a conclusion can please provide further info on how did you see if the caches are hit or not, according to what I see it looks like they should never be hit.

  3. added a commit that references this issue on Apr 10, 2024
  4. tokoko commented on Apr 10, 2024

    @tokoko
    CollaboratorAuthor

    hey, there were some cases when it should have been used but wasn't, but you're right, mostly it was never even supposed to be used because of different branches involved. btw, I already opened a PR to sort of address this. I switched CI scripts to use uv to install dependencies instead of pip and looks like it's much faster even without catching.

  5. tokoko commented on Apr 10, 2024

    @tokoko
    CollaboratorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions