You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Caches are almost never hit in CI workflows for pip install step despite taking considerable time for retrieval and upload sometimes.
Possible problems:
We are using old version of cache action
caches are scoped to branches, so for unit tests they are always recreated for new PRs. For integration tests, they should still work fine as they are ran with pull_request_target (?)
@tokoko
I think I saw a problem with with the caches, but before coming to a conclusion can please provide further info on how did you see if the caches are hit or not, according to what I see it looks like they should never be hit.
hey, there were some cases when it should have been used but wasn't, but you're right, mostly it was never even supposed to be used because of different branches involved. btw, I already opened a PR to sort of address this. I switched CI scripts to use uv to install dependencies instead of pip and looks like it's much faster even without catching.
Activity
tokoko commentedon Apr 1, 2024
cc @jeremyary
tmihalac commentedon Apr 10, 2024
@tokoko
I think I saw a problem with with the caches, but before coming to a conclusion can please provide further info on how did you see if the caches are hit or not, according to what I see it looks like they should never be hit.
fix: Caching in Github Workflows
tokoko commentedon Apr 10, 2024
hey, there were some cases when it should have been used but wasn't, but you're right, mostly it was never even supposed to be used because of different branches involved. btw, I already opened a PR to sort of address this. I switched CI scripts to use uv to install dependencies instead of pip and looks like it's much faster even without catching.
tokoko commentedon Apr 10, 2024
#4086