feast teardown does not remove register.db #1747

Expected Behavior

feast teardown, with the respective provider, should remove both the online store and registery.db.

Current Behavior

Apparantly, for local provider, it does not remove registry.db

Steps to reproduce

Follow the Getting started tutorial. As a last step, after feast materialize-incremental, try feast teardown.

Possible Solution

The code seems to unlink the file, but not sure if the _filepath is the correct one. If incorrect, it'll raise FileNotFoundError exception and just pass.

It seems odd that feast creates the registry.db correctly, passed on as path in feast_store.yaml but fails to delete it.