use python's copy lib rather than creating new copy method.

mavysavydav · mavysavydav · commit 91595cf96320 · 2021-10-06T17:06:40.000-07:00
Signed-off-by: David Y Liu &lt;davidyliuliu@gmail.com&gt;
diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py
@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+import copy
 import re
 import warnings
 from datetime import datetime, timedelta
@@ -226,7 +227,7 @@ def with_name(self, name: str):
             online=self.online,
         )
 
-        fv.set_projection(self.projection.copy)
+        fv.set_projection(copy.copy(self.projection))
         fv.projection.name_to_use = name
 
         return fv
diff --git a/sdk/python/feast/feature_view_projection.py b/sdk/python/feast/feature_view_projection.py
@@ -23,11 +23,6 @@ def to_proto(self):
 
         return feature_reference_proto
 
-    def copy(self):
-        return FeatureViewProjection(
-            name=self.name, name_to_use=self.name_to_use, features=self.features,
-        )
-
     @staticmethod
     def from_proto(proto: FeatureViewProjectionProto):
         ref = FeatureViewProjection(
diff --git a/sdk/python/feast/on_demand_feature_view.py b/sdk/python/feast/on_demand_feature_view.py
@@ -1,3 +1,4 @@
+import copy
 import functools
 from types import MethodType
 from typing import Dict, List, Union, cast
@@ -82,7 +83,7 @@ def with_name(self, name: str):
             name=self.name, features=self.features, inputs=self.inputs, udf=self.udf
         )
 
-        odfv.set_projection(self.projection.copy)
+        odfv.set_projection(copy.copy(self.projection))
         odfv.projection.name_to_use = name
 
         return odfv
