added copy method in FVProjections

mavysavydav · mavysavydav · commit d5cf2c579ec4 · 2021-10-06T16:50:02.000-07:00
Signed-off-by: David Y Liu &lt;davidyliuliu@gmail.com&gt;
diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py
@@ -226,8 +226,8 @@ def with_name(self, name: str):
             online=self.online,
         )
 
-        fv.set_projection(self.projection)
-        fv.projection.name_alias = name
+        fv.set_projection(self.projection.copy)
+        fv.projection.name_to_use = name
 
         return fv
 
diff --git a/sdk/python/feast/feature_view_projection.py b/sdk/python/feast/feature_view_projection.py
@@ -23,6 +23,11 @@ def to_proto(self):
 
         return feature_reference_proto
 
+    def copy(self):
+        return FeatureViewProjection(
+            name=self.name, name_to_use=self.name_to_use, features=self.features,
+        )
+
     @staticmethod
     def from_proto(proto: FeatureViewProjectionProto):
         ref = FeatureViewProjection(
diff --git a/sdk/python/feast/on_demand_feature_view.py b/sdk/python/feast/on_demand_feature_view.py
@@ -68,6 +68,25 @@ def __init__(
     def __hash__(self) -> int:
         return hash((id(self), self.name))
 
+    def with_name(self, name: str):
+        """
+        Produces a copy of this OnDemandFeatureView with the passed name.
+
+        Args:
+            name: Name to assign to the OnDemandFeatureView copy.
+
+        Returns:
+            A copy of this OnDemandFeatureView with the name replaced with the 'name' input.
+        """
+        odfv = OnDemandFeatureView(
+            name=self.name, features=self.features, inputs=self.inputs, udf=self.udf
+        )
+
+        odfv.set_projection(self.projection.copy)
+        odfv.projection.name_to_use = name
+
+        return odfv
+
     def to_proto(self) -> OnDemandFeatureViewProto:
         """
         Converts an on demand feature view object to its protobuf representation.

Original file line number	Diff line number	Diff line change
`@@ -226,8 +226,8 @@ def with_name(self, name: str):`
`226`	`226`	`online=self.online,`
`227`	`227`	`)`
`228`	`228`
`229`		`- fv.set_projection(self.projection)`
`230`		`- fv.projection.name_alias = name`
	`229`	`+ fv.set_projection(self.projection.copy)`
	`230`	`+ fv.projection.name_to_use = name`
`231`	`231`
`232`	`232`	`return fv`
`233`	`233`