Skip to content

Commit 6a3dd68

Browse files
felixwang9817achals
authored andcommitted
Remove incorrect comments
Signed-off-by: Felix Wang <wangfelix98@gmail.com> Signed-off-by: Achal Shah <achals@gmail.com>
1 parent 4343609 commit 6a3dd68

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

sdk/python/feast/feature_store.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1230,7 +1230,6 @@ def _get_online_features(
12301230
requested_request_feature_views,
12311231
requested_on_demand_feature_views,
12321232
)
1233-
12341233
set_usage_attribute("odfv", bool(grouped_odfv_refs))
12351234
set_usage_attribute("request_fv", bool(grouped_request_fv_refs))
12361235

@@ -1767,16 +1766,13 @@ def _get_feature_views_to_use(
17671766
return views_to_use
17681767

17691768
def stop_go_server(self):
1770-
if enable_go_feature_server(self.config):
1771-
# Lazily start the go server on the first request
1772-
if self._go_server is not None:
1773-
self._go_server.stop()
1769+
"""Force the Go feature server to shut down."""
1770+
if enable_go_feature_server(self.config) and self._go_server is not None:
1771+
self._go_server.stop()
17741772

17751773
def __exit__(self, exc_type, exc_value, traceback):
1776-
if enable_go_feature_server(self.config):
1777-
# Lazily start the go server on the first request
1778-
if self._go_server is not None:
1779-
self._go_server.stop()
1774+
if enable_go_feature_server(self.config) and self._go_server is not None:
1775+
self._go_server.stop()
17801776

17811777
@log_exceptions_and_usage
17821778
def serve(self, host: str, port: int, no_access_log: bool) -> None:

0 commit comments

Comments
 (0)