Remove Go feature server implementation of Python feature server

felixwang9817 · achals · commit 43436097def8 · 2022-03-08T12:16:34.000-08:00
Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;
Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -132,7 +132,6 @@ def __init__(
         self._registry._initialize_registry()
         self._provider = get_provider(self.config, self.repo_path)
         self._go_server = None
-        # print("New feature store")
 
     @log_exceptions
     def version(self) -> str:
@@ -1782,13 +1781,7 @@ def __exit__(self, exc_type, exc_value, traceback):
     @log_exceptions_and_usage
     def serve(self, host: str, port: int, no_access_log: bool) -> None:
         """Start the feature consumption server locally on a given port."""
-        if enable_go_feature_server(self.config):
-            # Lazily start the go server on the first request
-            if self._go_server is None:
-                self._go_server = GoServer(str(self.repo_path.absolute()), self.config)
-            self._go_server.start_http_server(host, port)
-        else:
-            feature_server.start_server(self, host, port, no_access_log)
+        feature_server.start_server(self, host, port, no_access_log)
 
     @log_exceptions_and_usage
     def get_feature_server_endpoint(self) -> Optional[str]:
diff --git a/sdk/python/feast/go_server.py b/sdk/python/feast/go_server.py
@@ -1,3 +1,16 @@
+# Copyright 2022 The Feast Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 import atexit
 import os
 import platform
@@ -152,24 +165,6 @@ def start_grpc_server(self):
             # Sleep for 0.1 second before retrying
             time.sleep(0.1)
 
-    def start_http_server(self, host: str, port: int):
-        if self.httpServerStarted:
-            return
-        for i in range(10):
-            try:
-                self.process.stdin.write(
-                    bytes(f"startHttp {host}:{port}\n", encoding="utf8")
-                )
-                self.process.stdin.flush()
-                self.httpServerStarted = True
-                break
-            except subprocess.CalledProcessError as error:
-                # If there is an exception
-                # go subprocess probably closed so pipe is closed
-                self.pipeClosed = True
-                self.stop()
-                raise errors.GoSubprocessConnectionFailed() from error
-
     def stop(self):
 
         # Only send sigkill if there's a problem telling go subprocess to stop
