Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

fixing wrong array key type for PHP 8.0 - #37

Merged
fe3dback merged 4 commits into
fe3dback:masterfrom
TheCodingHood:PHP_8
Mar 21, 2021
Merged

fe3dback merged 4 commits into
fe3dback:masterfrom
TheCodingHood:PHP_8

Conversation

@TheCodingHood

Copy link
Copy Markdown

Fixing [TypeError] str_replace(): Argument #2 ($replace) must be of type array|string, int given
on PHP 8

@fe3dback

Copy link
Copy Markdown
Owner

can you please fix travis for this project? i have no time for this project any more, but green ci status required to merge pr.

it seems composer updated in travis to version 2, and current lock is broken with latest php/composer version.

fe3dback
fe3dback previously approved these changes Mar 20, 2021
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 141

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 480
Relevant Lines: 480

💛 - Coveralls

@TheCodingHood

Copy link
Copy Markdown
Author

can you please fix travis for this project? i have no time for this project any more, but green ci status required to merge pr.

it seems composer updated in travis to version 2, and current lock is broken with latest php/composer version.

I have updated all dependencies and adapted the unit tests. Unfortunately, the dev dependencies now require a minimum of PHP 7.2. I have also adjusted this.

@fe3dback
fe3dback merged commit 2e1b2d2 into fe3dback:master Mar 21, 2021
@fe3dback

Copy link
Copy Markdown
Owner

thanks, it's great job

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants