Draggable Graphics#413
Conversation
clewis7
left a comment
There was a problem hiding this comment.
So, purpose of this PR is to create base class for handling moving Graphics?
LGTM codewise
I'm not sure I understand the relevancy of clip and multiplier. It looks like they are mostly always going to be None?
| collection_index: int | ||
| if relevant, the sub-index of this Graphic within the GraphicCollection | ||
|
|
||
| draggable: bool, default ``False`` |
There was a problem hiding this comment.
to clarify here: at this point in time all graphics are draggable right?
| collection_index: int | ||
| if relevant, the sub-index of this Graphic within the GraphicCollection | ||
|
|
||
| draggable: one of ``None``, ``"mouse"``, ``"kb"``, or ``"mouse+kb"``, default ``None`` |
There was a problem hiding this comment.
I would maybe specify that "kb" here is keyboard
| return self._multiplier | ||
|
|
||
| @multiplier.setter | ||
| def multiplier(self, value: np.ndarray): |
There was a problem hiding this comment.
Should there be more parsing here for size of value passed? Should always be a (1,3)
Also, should we allow passing a single float that would apply to xyz?
|
on hold until pygfx/pygfx#665 |
|
I forgot what usecase this was for, let's close unless we come across a usecase again |
closes #407