Skip to content

make hlut widget optional #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushalkolar merged 2 commits into from
Nov 3, 2023
Merged

make hlut widget optional #351

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
810f139
make hlut widget optional
Oct 31, 2023
0f76af2
Apply suggestions from code review
clewis7 Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions fastplotlib/widgets/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ def __init__(
grid_shape: Tuple[int, int] = None,
names: List[str] = None,
grid_plot_kwargs: dict = None,
histogram_widget: bool = False,
Comment thread
clewis7 marked this conversation as resolved.
Outdated
Comment thread
clewis7 marked this conversation as resolved.
Outdated
**kwargs,
):
"""
Expand Down Expand Up @@ -288,6 +289,9 @@ def __init__(
names: Optional[str]
gives names to the subplots

histogram_widget: bool, default False
determines whether each subplot is rendered with a Histogram LUT widget
Comment thread
clewis7 marked this conversation as resolved.
Outdated
Comment thread
clewis7 marked this conversation as resolved.
Outdated

kwargs: Any
passed to fastplotlib.graphics.Image

Expand Down Expand Up @@ -556,16 +560,17 @@ def __init__(
subplot.name = name
subplot.set_title(name)

hlut = HistogramLUT(
data=d,
image_graphic=ig,
name="histogram_lut"
)
if histogram_widget:
hlut = HistogramLUT(
data=d,
image_graphic=ig,
name="histogram_lut"
)

subplot.docks["right"].add_graphic(hlut)
subplot.docks["right"].size = 80
subplot.docks["right"].auto_scale(maintain_aspect=False)
subplot.docks["right"].controller.enabled = False
subplot.docks["right"].add_graphic(hlut)
subplot.docks["right"].size = 80
subplot.docks["right"].auto_scale(maintain_aspect=False)
subplot.docks["right"].controller.enabled = False

self.block_sliders = False
self._image_widget_toolbar = None
Expand Down