Skip to content

add desktop-only CI, add py312, remove ipywidgets import in plot.py, pin pygfx>=0.1.14#314

Merged
kushalkolar merged 3 commits intomasterfrom
ci-tweaks
Oct 3, 2023
Merged

add desktop-only CI, add py312, remove ipywidgets import in plot.py, pin pygfx>=0.1.14#314
kushalkolar merged 3 commits intomasterfrom
ci-tweaks

Conversation

@kushalkolar
Copy link
Copy Markdown
Member

  1. This adds CI to test that the examples work in an environment without jupyter and ipywidgets, to make sure that the examples work in a "minimal" env with only glfw.
  2. Add python 3.12 to CI
  3. remove ipywidgets import from layouters/_plot.py
  4. pin pygfx>=0.1.14

@kushalkolar kushalkolar requested a review from clewis7 October 3, 2023 18:45
Copy link
Copy Markdown
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Comment thread .github/workflows/ci.yml
@kushalkolar kushalkolar merged commit 3965bb1 into master Oct 3, 2023
@kushalkolar kushalkolar deleted the ci-tweaks branch October 3, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants