Skip to content

allow image types other than float32 #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushalkolar merged 1 commit into from
Apr 8, 2026
+6 −2
Merged

allow image types other than float32 #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fastplotlib/graphics/features/_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from itertools import product
from math import ceil
from warnings import warn

import cmap as cmap_lib
import numpy as np
Expand Down Expand Up @@ -104,8 +105,11 @@ def _fix_data(self, data):
"it must be of shape [rows, cols], [rows, cols, 3] or [rows, cols, 4]"
)

# let's just cast to float32 always
return data.astype(np.float32)
if data.itemsize == 8:
warn(f"casting {array.dtype} array to float32")
return data.astype(np.float32)

return data

def __iter__(self):
self._iter = product(enumerate(self.row_indices), enumerate(self.col_indices))
Expand Down