Skip to content

Add optional support for digit separators and cpp prefixes #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaewc wants to merge 11 commits into
base: main
Choose a base branch
from
+138 −16
Open

Add optional support for digit separators and cpp prefixes #369

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
70aa9a8
Add options for digit separators and prefix skipping
zaewc Jan 22, 2026
4abcd60
Implement digit separator skipping in number parsing
zaewc Jan 23, 2026
456e4c5
Implement prefix skipping in from_chars_advanced
zaewc Jan 25, 2026
587d890
Reformat
zaewc Feb 8, 2026
b50eeab
Handle digit separators in exponent and fraction parsing
zaewc Feb 8, 2026
ad90d9a
refactor: simplify prefix skipping conditions
zaewc Feb 8, 2026
b9ffbe8
refector: pre-calculate digit separator presence and value
zaewc Feb 8, 2026
a6c8710
refactor: simplify leading zero detection
zaewc Feb 8, 2026
c3b634e
Add test cases for digit separators
zaewc Feb 24, 2026
1403169
Implement digit separator skipping in exponent parsing
zaewc Feb 24, 2026
43c1796
refactor: simplify fractional digit count calculation by removing an …
zaewc Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test cases for digit separators
  • Loading branch information
@zaewc
zaewc committed Feb 24, 2026
commit c3b634e24f5a515212dc86d79860fa5be519bc38
53 changes: 52 additions & 1 deletion tests/basictest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,57 @@ TEST_CASE("decimal_point_parsing") {
}
}

TEST_CASE("digit_separator") {
double result;
fast_float::parse_options options{};
options.digit_separator = '_';
{
std::string const input = "1_000";
auto answer = fast_float::from_chars_advanced(
input.data(), input.data() + input.size(), result, options);
CHECK_MESSAGE(answer.ec == std::errc(), "expected parse success");
CHECK_MESSAGE(answer.ptr == input.data() + input.size(),
"Parsing should have stopped at end");
CHECK_EQ(result, 1000.0);
}
{
std::string const input = "1.00_5";
auto answer = fast_float::from_chars_advanced(
input.data(), input.data() + input.size(), result, options);
CHECK_MESSAGE(answer.ec == std::errc(), "expected parse success");
CHECK_MESSAGE(answer.ptr == input.data() + input.size(),
"Parsing should have stopped at end");
CHECK_EQ(result, 1.005);
}
{
std::string const input = "1e1_0";
auto answer = fast_float::from_chars_advanced(
input.data(), input.data() + input.size(), result, options);
CHECK_MESSAGE(answer.ec == std::errc(), "expected parse success");
CHECK_MESSAGE(answer.ptr == input.data() + input.size(),
"Parsing should have stopped at end");
CHECK_EQ(result, 1e10);
}
{
std::string const input = "1_5e1_2";
auto answer = fast_float::from_chars_advanced(
input.data(), input.data() + input.size(), result, options);
CHECK_MESSAGE(answer.ec == std::errc(), "expected parse success");
CHECK_MESSAGE(answer.ptr == input.data() + input.size(),
"Parsing should have stopped at end");
CHECK_EQ(result, 15e12);
}
{
std::string const input = "1_5.0_5e1_2";
auto answer = fast_float::from_chars_advanced(
input.data(), input.data() + input.size(), result, options);
CHECK_MESSAGE(answer.ec == std::errc(), "expected parse success");
CHECK_MESSAGE(answer.ptr == input.data() + input.size(),
"Parsing should have stopped at end");
CHECK_EQ(result, 15.05e12);
}
}

TEST_CASE("issue19") {
std::string const input = "234532.3426362,7869234.9823,324562.645";
double result;
Expand Down Expand Up @@ -2452,4 +2503,4 @@ TEST_CASE("integer_times_pow10") {
all::verify_integer_times_pow10(std::numeric_limits<uint64_t>::max(), 42);
all::verify_integer_times_pow10(std::numeric_limits<uint64_t>::max(), -42);
}
}
}