Skip to content

Implemented multiplication of integer by a power of 10 #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 10 commits into from
Sep 18, 2025
Merged

Implemented multiplication of integer by a power of 10 #320

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7b8f045
implemented multiplication of integer by power of 10
toughengineer Sep 2, 2025
a134561
added missing `inline` specifiers
toughengineer Sep 2, 2025
cc90f24
added some tests
toughengineer Sep 2, 2025
6be07d6
inlining Clinger's fast path because why not,
toughengineer Sep 3, 2025
763558b
cleaned up tests
toughengineer Sep 3, 2025
20a7383
renamed the function, cleaned up return type
toughengineer Sep 5, 2025
6702cd4
added doc section in the README,
toughengineer Sep 5, 2025
e124635
added lacking overloads to avoid potential ambiguity
toughengineer Sep 5, 2025
7ae62ee
finally got the anti-ambiguity overloads right?
toughengineer Sep 5, 2025
0a23032
now finally got the anti-ambiguity overloads right, right?
toughengineer Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
finally got the anti-ambiguity overloads right?
  • Loading branch information
@toughengineer
toughengineer committed Sep 5, 2025
commit 7ae62ee0d52675e9c853aeded4ede8a32f866615
24 changes: 8 additions & 16 deletions include/fast_float/parse_number.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,25 +373,17 @@ integer_times_pow10(int64_t mantissa, int decimal_exponent) noexcept {

// the following overloads are here to avoid surprising ambiguity for int,
// unsigned, etc.
#if !defined(_MSC_VER)
FASTFLOAT_CONSTEXPR20 inline double
integer_times_pow10(unsigned long long mantissa,
int decimal_exponent) noexcept {
return integer_times_pow10(static_cast<uint64_t>(mantissa), decimal_exponent);
}

FASTFLOAT_CONSTEXPR20 inline double
integer_times_pow10(long long mantissa, int decimal_exponent) noexcept {
return integer_times_pow10(static_cast<int64_t>(mantissa), decimal_exponent);
}
#endif
FASTFLOAT_CONSTEXPR20 inline double
integer_times_pow10(unsigned mantissa, int decimal_exponent) noexcept {
template <typename Int>
FASTFLOAT_CONSTEXPR20 inline std::enable_if_t<
std::is_integral<Int>::value && !std::is_signed<Int>::value, double>
integer_times_pow10(Int mantissa, int decimal_exponent) noexcept {
return integer_times_pow10(static_cast<uint64_t>(mantissa), decimal_exponent);
}

FASTFLOAT_CONSTEXPR20 inline double
integer_times_pow10(int mantissa, int decimal_exponent) noexcept {
template <typename Int>
FASTFLOAT_CONSTEXPR20 inline std::enable_if_t<
std::is_integral<Int>::value && std::is_signed<Int>::value, double>
integer_times_pow10(Int mantissa, int decimal_exponent) noexcept {
return integer_times_pow10(static_cast<int64_t>(mantissa), decimal_exponent);
}

Expand Down